Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix when build model with strict=False for load state dict #147

Merged
merged 18 commits into from
Apr 9, 2024

Conversation

KonstantinWilleke
Copy link
Collaborator

No description provided.

nnfabrik/utility/nn_helpers.py Outdated Show resolved Hide resolved
nnfabrik/utility/nn_helpers.py Outdated Show resolved Hide resolved
nnfabrik/utility/nn_helpers.py Outdated Show resolved Hide resolved
@MaxFBurg
Copy link
Member

I think it would be cool and helpful to have this feature. I just added a review, @KonstantinWilleke could you have a quick look and commit the changes I requested? (if @ArneNx is fine with me reviewing instead?)

@ArneNx
Copy link
Collaborator

ArneNx commented Mar 22, 2024

Thank you for handling this Max. I don't use this anymore, so I'm fine if you take over on this review.

@ArneNx ArneNx removed their request for review March 22, 2024 11:14
@MaxFBurg MaxFBurg merged commit 29f22bc into sinzlab:master Apr 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants