refactor(tooltip): simplify tooltip rendering logic by removing condi…

…tional rendering for visibility
sipe-team · Dec 2, 2024 · ccca3cc · ccca3cc
1 parent cd5d66e
commit ccca3cc
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 19 deletions.
diff --git a/packages/tooltip/src/Tooltip.module.css b/packages/tooltip/src/Tooltip.module.css
@@ -15,9 +15,6 @@
   transform: scale(0.95);
   transition: opacity 0.3s ease, transform 0.3s ease;
   pointer-events: none;
-
-  top: -9999px;
-  left: -9999px;
 }
 
 .tooltip.visible {

diff --git a/packages/tooltip/src/Tooltip.tsx b/packages/tooltip/src/Tooltip.tsx
@@ -85,22 +85,18 @@ export const Tooltip = forwardRef(function Tooltip(
       >
         {children}
       </Component>
-      {isVisible &&
-        createPortal(
-          <div
-            ref={tooltipRef}
-            className={clsx(
-              styles.tooltip,
-              styles[placement],
-              tooltipClassName,
-              { [styles.visible]: isVisible },
-            )}
-            style={{ ...tooltipStyles, ...tooltipStyle }}
-          >
-            {tooltipContent}
-          </div>,
-          document.body,
-        )}
+      {createPortal(
+        <div
+          ref={tooltipRef}
+          className={clsx(styles.tooltip, styles[placement], tooltipClassName, {
+            [styles.visible]: isVisible,
+          })}
+          style={{ ...tooltipStyles, ...tooltipStyle }}
+        >
+          {tooltipContent}
+        </div>,
+        document.body,
+      )}
     </>
   );
 });