Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/contacts UI #45

Merged
merged 20 commits into from
Feb 20, 2025
Merged

Feat/contacts UI #45

merged 20 commits into from
Feb 20, 2025

Conversation

saisab29
Copy link
Collaborator

No description provided.

<div className="text-blue-600 hover:underline cursor-pointer">
{row.original.email}
</div>
{row.original.list_names?.length > 0 && (

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if list_names is Array or not

if (!isValidEmail || contactData) return; // Skip if invalid format

const handler = setTimeout(() => {
if (email) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract this function

const listsToAdd = listIds.filter(
(listId) => !currentListIds.includes(listId)
);
console.log("listsToAdd", listsToAdd);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

import { ContactFormSchema } from "@/lib/type/contact";
import { MultiSelect } from "../../../../components/multi-select";

interface List {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extract and reuse this instead of creating in multiple files


useEffect(() => {
const subscription = form.watch((value, { name }) => {
if (name === "email") {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract function and if used in multiple file then extract in seperate file

<FormItem>
<div className="text-sm font-medium">Attributes</div>
<FormControl>
<textarea

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make TextArea component

@saisab29 saisab29 merged commit 78de00b into develop Feb 20, 2025
1 check passed
@saisab29 saisab29 deleted the feat/contacts-UI branch February 20, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants