-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/contacts UI #45
Feat/contacts UI #45
Conversation
…te import page ui
74a792b
to
708c6c0
Compare
<div className="text-blue-600 hover:underline cursor-pointer"> | ||
{row.original.email} | ||
</div> | ||
{row.original.list_names?.length > 0 && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if list_names is Array or not
if (!isValidEmail || contactData) return; // Skip if invalid format | ||
|
||
const handler = setTimeout(() => { | ||
if (email) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extract this function
const listsToAdd = listIds.filter( | ||
(listId) => !currentListIds.includes(listId) | ||
); | ||
console.log("listsToAdd", listsToAdd); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this
import { ContactFormSchema } from "@/lib/type/contact"; | ||
import { MultiSelect } from "../../../../components/multi-select"; | ||
|
||
interface List { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extract and reuse this instead of creating in multiple files
|
||
useEffect(() => { | ||
const subscription = form.watch((value, { name }) => { | ||
if (name === "email") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extract function and if used in multiple file then extract in seperate file
<FormItem> | ||
<div className="text-sm font-medium">Attributes</div> | ||
<FormControl> | ||
<textarea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make TextArea
component
No description provided.