Fix Firefox 121 start issue on Mac. #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whimboo
reviewed
Dec 22, 2023
| !firefoxConfig.beta && | ||
| !firefoxConfig.developer | ||
| ) { | ||
| ffOptions.setBinary('/Applications/Firefox.app/Contents/MacOS/firefox'); |
There was a problem hiding this comment.
@soulgalore actually it would be better if you only set the app bundle on MacOS. This would prevent issues with the real binary that you usually should read out of the info.plist file. geckodriver itself will find the binary on its own.
There was a problem hiding this comment.
I'm gonna remove this fix when it's fixed upstream. It was bold releasing 121 the week before Christmas so I just want to get it to work :)
There was a problem hiding this comment.
It would be better to let Selenium Manager handle this. It will find the Firefox binary on the host and then match it with the appropriate GeckoDriver version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2041