remove endpoint config

sitespeedio · Dec 27, 2024 · 86074d1 · 86074d1
1 parent 1ad9d96
commit 86074d1
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 9 deletions.
diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml
@@ -84,4 +84,4 @@ jobs:
     - name: Run Chrome test using compare plugin
       run: node bin/sitespeed.js --compare.id compare --compare.saveBaseline --compare.baselinePath test/ http://127.0.0.1:3001/simple/ --xvfb
     - name: Run Chrome test sending data to GCS
-      run: node bin/sitespeed.js http://127.0.0.1:3001/simple/ --xvfb -n 1 --gcs.bucketname sitespeed --gcs.projectId sitespeed --gcs.apiEndpoint http://localhost:8081
+      run: STORAGE_EMULATOR_HOST="http://localhost:8081" node bin/sitespeed.js http://127.0.0.1:3001/simple/ --xvfb -n 1 --gcs.bucketname sitespeed --gcs.projectId sitespeed
diff --git a/lib/cli/cli.js b/lib/cli/cli.js
@@ -1698,10 +1698,6 @@ export async function parseCommandLine() {
       describe: 'Name of the Google Cloud storage bucket',
       group: 'GoogleCloudStorage'
     })
-    .option('gcs.apiEndpoint', {
-      describe: 'The URL to the API endpoint, good for using fake-gcs-server',
-      group: 'GoogleCloudStorage'
-    })
     .option('gcs.public', {
       describe:
         'Make uploaded results to Google Cloud storage publicly readable.',

diff --git a/lib/plugins/gcs/index.js b/lib/plugins/gcs/index.js
@@ -20,10 +20,6 @@ async function uploadLatestFiles(dir, gcsOptions, prefix) {
     keyFilename: gcsOptions.key
   };
 
-  if (gcsOptions.apiEndpoint) {
-    config.apiEndpoint = gcsOptions.apiEndpoint;
-  }
-
   const storage = new Storage(config);
   const bucket = storage.bucket(gcsOptions.bucketname);