Merge branch 'main' into bt-24.2.0

sitespeedio · Feb 6, 2025 · bf3068b · bf3068b
2 parents 5d0fe51 + 90984b1
commit bf3068b
Show file tree

Hide file tree

Showing 22 changed files with 259 additions and 322 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,17 @@
 # CHANGELOG - sitespeed.io  (we use [semantic versioning](https://semver.org))
 
+## 36.2.5 - 2025-02-03
+### Fixed
+* The check for sending Android test through APIs was broken in 36.2.4, fixed in [#4428](https://github.com/sitespeedio/sitespeed.io/pull/4428).
+
+## 36.2.4 - 2025-02-02
+### Fixed
+* The GitHub actions tests on Windows was broken. I think GitHub changed tere heir setup: Suddenly the path to plugins was broken. Rerunning old test that used to work, failed with the same code on our side. It's fixed by [#4426](https://github.com/sitespeedio/sitespeed.io/pull/4426).
+
+* We have had issues with parsing Android configuration because of the `--android` flag to enable Android tests. The problem was that in some cases the internal configuration object become an Array (instead of an object) and that made some objects to do not work. The PR [#4422](https://github.com/sitespeedio/sitespeed.io/pull/4422) removes `--android` from the cli help, however it will still work as before.
+
+* Fix so API calls also looks for `--android.enabled` to know if you want to test on Android [#4427](https://github.com/sitespeedio/sitespeed.io/pull/4427).
+
 ## 36.2.3 - 2025-01-30
 ### Fixed
 * Even better handling of missing runtime settings [#4420](https://github.com/sitespeedio/sitespeed.io/pull/4420).

diff --git a/Dockerfile b/Dockerfile
@@ -1,4 +1,4 @@
-FROM sitespeedio/webbrowsers:chrome-132.0-firefox-134.0-edge-132.0
+FROM sitespeedio/webbrowsers:chrome-133.0-firefox-135.0-edge-132.0
 
 ARG TARGETPLATFORM=linux/amd64
 

diff --git a/bin/sitespeed.js b/bin/sitespeed.js
@@ -46,7 +46,10 @@ async function api(options) {
 
   if (apiOptions.mobile) {
     apiOptions.api.testType = 'emulatedMobile';
-  } else if (apiOptions.android) {
+  } else if (
+    apiOptions.android === true ||
+    (apiOptions.android && apiOptions.android.enabled === true)
+  ) {
     apiOptions.api.testType = 'android';
   } else if (apiOptions.safari && apiOptions.safari.ios) {
     apiOptions.api.testType = 'ios';

diff --git a/docs/_includes/version/browsertime.txt b/docs/_includes/version/browsertime.txt
@@ -1 +1 @@
-24.1.1
+24.2.0
diff --git a/docs/_includes/version/server.txt b/docs/_includes/version/server.txt
@@ -1 +1 @@
-1.3.0
+1.4.0
diff --git a/docs/_includes/version/sitespeed.io.txt b/docs/_includes/version/sitespeed.io.txt
@@ -1 +1 @@
-36.2.3
+36.2.5
diff --git a/docs/_includes/version/testrunner.txt b/docs/_includes/version/testrunner.txt
@@ -1 +1 @@
-1.0.5
+1.0.7
diff --git a/docs/documentation/sitespeed.io/configuration/config.md b/docs/documentation/sitespeed.io/configuration/config.md
@@ -326,7 +326,7 @@ Options:
       --browsertime.enableVideoRun, --enableVideoRun          Make one extra run that collects video and visual metrics. This means you can do your runs with --visualMetrics true --video false --enableVideoRun true to collect visual metrics from all runs and save a video from the profile/video run. If you run it together with --enableProfileRun it will also collect profiling race.  [boolean]
       --browsertime.cjs, --cjs                                Load scripting files that ends with .js as common js. Default (false) loads files as esmodules.  [boolean] [default: false]
       --browsertime.tcpdump, --tcpdump                        Collect a tcpdump for each tested URL. The user that runs sitespeed.io should have sudo rights for tcpdump to work.  [boolean] [default: false]
-      --browsertime.android, --android                        Short key to use Android. Will automatically use com.android.chrome for Chrome and stable Firefox. If you want to use another Chrome version, use --chrome.android.package  [boolean] [default: false]
+      --browsertime.android.enabled, --android.enabled        Short key to use Android. Will automatically use com.android.chrome for Chrome and stable Firefox. If you want to use another Chrome version, use --chrome.android.package  [boolean] [default: false]
       --browsertime.iqr                                       Use IQR, or Inter Quartile Range filtering filters data based on the spread of the data. See  https://en.wikipedia.org/wiki/Interquartile_range. In some cases, IQR filtering may not filter out anything. This can happen if the acceptable range is wider than the bounds of your dataset.  [boolean] [default: false]
       --browsertime.preWarmServer, --preWarmServer            Do pre test requests to the URL(s) that you want to test that is not measured. Do that to make sure your web server is ready to serve. The pre test requests is done with another browser instance that is closed after pre testing is done.  [boolean] [default: false]
       --browsertime.preWarmServerWaitTime                     The wait time before you start the real testing after your pre-cache request.  [number] [default: 5000]

diff --git a/docs/feed/browsertime.atom b/docs/feed/browsertime.atom
@@ -2,7 +2,7 @@
 <feed xmlns="http://www.w3.org/2005/Atom">
     <id>browsertime-release-feed</id>
     <title>browsertime release feed</title>
-    <updated>2025-01-29T06:22:13.732Z</updated>
+    <updated>2025-01-29T07:51:38.590Z</updated>
     <generator>https://github.com/jpmonette/feed</generator>
     <author>
         <name>Peter Hedenskog</name>

diff --git a/docs/feed/browsertime.rss b/docs/feed/browsertime.rss
@@ -4,7 +4,7 @@
         <title>browsertime release feed</title>
         <link>https://www.sitespeed.io</link>
         <description>New releases and changelog feed of browsertime</description>
-        <lastBuildDate>Wed, 29 Jan 2025 06:22:13 GMT</lastBuildDate>
+        <lastBuildDate>Wed, 29 Jan 2025 07:51:38 GMT</lastBuildDate>
         <docs>https://validator.w3.org/feed/docs/rss2.html</docs>
         <generator>https://github.com/jpmonette/feed</generator>
         <language>en</language>

diff --git a/docs/feed/server.atom b/docs/feed/server.atom
@@ -2,7 +2,7 @@
 <feed xmlns="http://www.w3.org/2005/Atom">
     <id>server-release-feed</id>
     <title>server release feed</title>
-    <updated>2025-01-30T13:38:22.186Z</updated>
+    <updated>2025-01-30T15:28:50.545Z</updated>
     <generator>https://github.com/jpmonette/feed</generator>
     <author>
         <name>Peter Hedenskog</name>
@@ -15,6 +15,21 @@
     <icon>http://www.sitespeed.io/favicon.ico</icon>
     <rights>All rights reserved 2022, Peter Hedenskog and team</rights>
     <category term="Web Performance"/>
+    <entry>
+        <title type="html"><![CDATA[server 1.3.0]]></title>
+        <id>https://github.com/sitespeedio/server/blob/main/CHANGELOG.md#1.3.0</id>
+        <link href="https://github.com/sitespeedio/server/blob/main/CHANGELOG.md#1.3.0"/>
+        <updated>2025-01-30T00:00:00.000Z</updated>
+        <summary type="html"><![CDATA[<h3>Added</h3>
+ <ul>
+<li>Add link to active test in search <a href="https://github.com/sitespeedio/onlinetest/pull/129">#129</a>.</li>
+</ul>
+]]></summary>
+        <author>
+            <name>Sitespeed.io</name>
+            <uri>https://www.sitespeed.io</uri>
+        </author>
+    </entry>
     <entry>
         <title type="html"><![CDATA[server 1.2.0]]></title>
         <id>https://github.com/sitespeedio/server/blob/main/CHANGELOG.md#1.2.0</id>
@@ -176,21 +191,6 @@
  <ul>
 <li>The internal configuration was broken in the way that removing/adding testrunners failed removing correct configurations <a href="https://github.com/sitespeedio/onlinetest/pull/84">#84</a>. This fix also needs <a href="https://github.com/sitespeedio/onlinetest/pull/83">#83</a> in the testrunners.</li>
 </ul>
-]]></summary>
-        <author>
-            <name>Sitespeed.io</name>
-            <uri>https://www.sitespeed.io</uri>
-        </author>
-    </entry>
-    <entry>
-        <title type="html"><![CDATA[server 0.4.1]]></title>
-        <id>https://github.com/sitespeedio/server/blob/main/CHANGELOG.md#0.4.1</id>
-        <link href="https://github.com/sitespeedio/server/blob/main/CHANGELOG.md#0.4.1"/>
-        <updated>2024-08-23T00:00:00.000Z</updated>
-        <summary type="html"><![CDATA[<h3>Fixed</h3>
- <ul>
-<li>Fix bug so you can choose emulated mobile in GUI <a href="https://github.com/sitespeedio/onlinetest/pull/76">#76</a>.</li>
-</ul>
 ]]></summary>
         <author>
             <name>Sitespeed.io</name>

diff --git a/docs/feed/server.rss b/docs/feed/server.rss
@@ -4,13 +4,24 @@
         <title>server release feed</title>
         <link>https://www.sitespeed.io</link>
         <description>New releases and changelog feed of server</description>
-        <lastBuildDate>Thu, 30 Jan 2025 13:38:22 GMT</lastBuildDate>
+        <lastBuildDate>Thu, 30 Jan 2025 15:28:50 GMT</lastBuildDate>
         <docs>https://validator.w3.org/feed/docs/rss2.html</docs>
         <generator>https://github.com/jpmonette/feed</generator>
         <language>en</language>
         <copyright>All rights reserved 2022, Peter Hedenskog and team</copyright>
         <category>Web Performance</category>
         <atom:link href="https://www.sitespeed.io/feed/server.rss" rel="self" type="application/rss+xml"/>
+        <item>
+            <title><![CDATA[server 1.3.0]]></title>
+            <link>https://github.com/sitespeedio/server/blob/main/CHANGELOG.md#1.3.0</link>
+            <guid>https://github.com/sitespeedio/server/blob/main/CHANGELOG.md#1.3.0</guid>
+            <pubDate>Thu, 30 Jan 2025 00:00:00 GMT</pubDate>
+            <description><![CDATA[<h3>Added</h3>
+ <ul>
+<li>Add link to active test in search <a href="https://github.com/sitespeedio/onlinetest/pull/129">#129</a>.</li>
+</ul>
+]]></description>
+        </item>
         <item>
             <title><![CDATA[server 1.2.0]]></title>
             <link>https://github.com/sitespeedio/server/blob/main/CHANGELOG.md#1.2.0</link>
@@ -140,17 +151,6 @@
  <ul>
 <li>The internal configuration was broken in the way that removing/adding testrunners failed removing correct configurations <a href="https://github.com/sitespeedio/onlinetest/pull/84">#84</a>. This fix also needs <a href="https://github.com/sitespeedio/onlinetest/pull/83">#83</a> in the testrunners.</li>
 </ul>
-]]></description>
-        </item>
-        <item>
-            <title><![CDATA[server 0.4.1]]></title>
-            <link>https://github.com/sitespeedio/server/blob/main/CHANGELOG.md#0.4.1</link>
-            <guid>https://github.com/sitespeedio/server/blob/main/CHANGELOG.md#0.4.1</guid>
-            <pubDate>Fri, 23 Aug 2024 00:00:00 GMT</pubDate>
-            <description><![CDATA[<h3>Fixed</h3>
- <ul>
-<li>Fix bug so you can choose emulated mobile in GUI <a href="https://github.com/sitespeedio/onlinetest/pull/76">#76</a>.</li>
-</ul>
 ]]></description>
         </item>
     </channel>

diff --git a/docs/feed/sitespeed.io.atom b/docs/feed/sitespeed.io.atom
@@ -2,7 +2,7 @@
 <feed xmlns="http://www.w3.org/2005/Atom">
     <id>sitespeed.io-release-feed</id>
     <title>sitespeed.io release feed</title>
-    <updated>2025-01-30T13:40:48.761Z</updated>
+    <updated>2025-02-03T08:20:01.115Z</updated>
     <generator>https://github.com/jpmonette/feed</generator>
     <author>
         <name>Peter Hedenskog</name>
@@ -16,6 +16,42 @@
     <icon>http://www.sitespeed.io/favicon.ico</icon>
     <rights>All rights reserved 2022, Peter Hedenskog and team</rights>
     <category term="Web Performance"/>
+    <entry>
+        <title type="html"><![CDATA[sitespeed.io 36.2.5]]></title>
+        <id>https://github.com/sitespeedio/sitespeed.io/blob/main/CHANGELOG.md#36.2.5</id>
+        <link href="https://github.com/sitespeedio/sitespeed.io/blob/main/CHANGELOG.md#36.2.5"/>
+        <updated>2025-02-03T00:00:00.000Z</updated>
+        <summary type="html"><![CDATA[<h3>Fixed</h3>
+ <ul>
+<li>The check for sending Android test through APIs was broken in 36.2.4, fixed in <a href="https://github.com/sitespeedio/sitespeed.io/pull/4428">#4428</a>.</li>
+</ul>
+]]></summary>
+        <author>
+            <name>Sitespeed.io</name>
+            <uri>https://www.sitespeed.io</uri>
+        </author>
+    </entry>
+    <entry>
+        <title type="html"><![CDATA[sitespeed.io 36.2.4]]></title>
+        <id>https://github.com/sitespeedio/sitespeed.io/blob/main/CHANGELOG.md#36.2.4</id>
+        <link href="https://github.com/sitespeedio/sitespeed.io/blob/main/CHANGELOG.md#36.2.4"/>
+        <updated>2025-02-02T00:00:00.000Z</updated>
+        <summary type="html"><![CDATA[<h3>Fixed</h3>
+ <ul>
+<li>The GitHub actions tests on Windows was broken. I think GitHub changed tere heir setup: Suddenly the path to plugins was broken. Rerunning old test that used to work, failed with the same code on our side. It&#39;s fixed by <a href="https://github.com/sitespeedio/sitespeed.io/pull/4426">#4426</a>.</li>
+</ul>
+ <ul>
+<li>We have had issues with parsing Android configuration because of the <code>--android</code> flag to enable Android tests. The problem was that in some cases the internal configuration object become an Array (instead of an object) and that made some objects to do not work. The PR <a href="https://github.com/sitespeedio/sitespeed.io/pull/4422">#4422</a> removes <code>--android</code> from the cli help, however it will still work as before.</li>
+</ul>
+ <ul>
+<li>Fix so API calls also looks for <code>--android.enabled</code> to know if you want to test on Android <a href="https://github.com/sitespeedio/sitespeed.io/pull/4427">#4427</a>.</li>
+</ul>
+]]></summary>
+        <author>
+            <name>Sitespeed.io</name>
+            <uri>https://www.sitespeed.io</uri>
+        </author>
+    </entry>
     <entry>
         <title type="html"><![CDATA[sitespeed.io 36.2.3]]></title>
         <id>https://github.com/sitespeedio/sitespeed.io/blob/main/CHANGELOG.md#36.2.3</id>
@@ -143,88 +179,6 @@
  <ul>
 <li>Disable the CPU/enableProfileRun check introduced in 36.0.0, that affected too many users <a href="https://github.com/sitespeedio/sitespeed.io/pull/4408">#4408</a>.</li>
 </ul>
-]]></summary>
-        <author>
-            <name>Sitespeed.io</name>
-            <uri>https://www.sitespeed.io</uri>
-        </author>
-    </entry>
-    <entry>
-        <title type="html"><![CDATA[sitespeed.io 36.0.0]]></title>
-        <id>https://github.com/sitespeedio/sitespeed.io/blob/main/CHANGELOG.md#36.0.0</id>
-        <link href="https://github.com/sitespeedio/sitespeed.io/blob/main/CHANGELOG.md#36.0.0"/>
-        <updated>2025-01-21T00:00:00.000Z</updated>
-        <summary type="html"><![CDATA[<h3>Added</h3>
- <ul>
-<li>Update to Coach-core 8.1.1 <a href="https://github.com/sitespeedio/sitespeed.io/pull/4363">#4363</a></li>
-</ul>
- <ul>
-<li>Use the offical Slack plugin instead of node-slack <a href="https://github.com/sitespeedio/sitespeed.io/pull/4360">#4360</a>.</li>
-</ul>
- <ul>
-<li>Firefox 134, Chrome 132 and NodeJS 22 in the Docker container <a href="https://github.com/sitespeedio/sitespeed.io/pull/4395">#4395</a>, <a href="https://github.com/sitespeedio/sitespeed.io/pull/4396">#4396</a> and <a href="https://github.com/sitespeedio/sitespeed.io/pull/4405">#4405</a></li>
-</ul>
- <ul>
-<li>Let the Docker container output the CPU architecture for easier error reporting <a href="https://github.com/sitespeedio/sitespeed.io/pull/4404">#4404</a>.</li>
-</ul>
-<h3>Fixed</h3>
- <ul>
-<li>Replace dependencies with local code:</li>
-</ul>
- <ul>
-<li>Fix cli command: Use <code>--summaryDetail</code> (not summary-detail) <a href="https://github.com/sitespeedio/sitespeed.io/pull/4376">#4376</a>.</li>
-</ul>
- <ul>
-<li>Remove connectivity output from text since it was broken <a href="https://github.com/sitespeedio/sitespeed.io/pull/4375">#4375</a>.</li>
-</ul>
- <ul>
-<li>Upgrade to co2.js 0.16.4 <a href="https://github.com/sitespeedio/sitespeed.io/pull/4353">#4353</a>.</li>
-</ul>
- <ul>
-<li>Make sure co2 data is only read once at startup <a href="https://github.com/sitespeedio/sitespeed.io/pull/4352">#4352</a>.</li>
-</ul>
- <ul>
-<li>Making the slim container a little smaller <a href="https://github.com/sitespeedio/sitespeed.io/pull/4355">#4355</a>.</li>
-</ul>
- <ul>
-<li>Ugrade to google-cloud/storage-7.14.0 <a href="https://github.com/sitespeedio/sitespeed.io/pull/4361">#4361</a>.</li>
-</ul>
- <ul>
-<li>Upgrade to AWS client 3.717.0 <a href="https://github.com/sitespeedio/sitespeed.io/pull/4368">#4368</a></li>
-</ul>
- <ul>
-<li>Removed the webdriver manager in the Docker container <a href="https://github.com/sitespeedio/sitespeed.io/pull/4390">4390</a>. We don&#39;t use it but on MacOS Selenium still uses it to find the driver for Safari so we can only remove it in Docker.</li>
-</ul>
- <ul>
-<li>Fix Wilcoxon NaN values when running the compare plugin <a href="https://github.com/sitespeedio/sitespeed.io/pull/4402">#4402</a>.</li>
-</ul>
-]]></summary>
-        <author>
-            <name>Sitespeed.io</name>
-            <uri>https://www.sitespeed.io</uri>
-        </author>
-    </entry>
-    <entry>
-        <title type="html"><![CDATA[sitespeed.io 35.7.5]]></title>
-        <id>https://github.com/sitespeedio/sitespeed.io/blob/main/CHANGELOG.md#35.7.5</id>
-        <link href="https://github.com/sitespeedio/sitespeed.io/blob/main/CHANGELOG.md#35.7.5"/>
-        <updated>2024-12-23T00:00:00.000Z</updated>
-        <summary type="html"><![CDATA[<h3>Fixed</h3>
- <ul>
-<li>Update to faststat 0.0.7 <a href="https://github.com/sitespeedio/sitespeed.io/pull/4347">#4347</a>.</li>
-</ul>
- <ul>
-<li>Update dev dependencies <a href="https://github.com/sitespeedio/sitespeed.io/pull/4345">#4345</a>.</li>
-</ul>
- <ul>
-<li>Let analysisstorer know about webpagereplay so that correct information is displayed <a href="https://github.com/sitespeedio/sitespeed.io/pull/4349">#4349</a>.</li>
-</ul>
- <ul>
-<li>Pass on webpagereplay flag to browsertime <a href="https://github.com/sitespeedio/sitespeed.io/pull/4350">#4350</a>.</li>
-</ul>
- <ul>
-<li>Update to Browsertime 23.5.0 <a href="https://github.com/sitespeedio/sitespeed.io/pull/4351">#4351</a></li>
-</ul>
 ]]></summary>
         <author>
             <name>Sitespeed.io</name>