feat: add --tmux flag (deprecates sk-tmux, fixes #596)
#603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
November 20, 2024 21:32
This was
linked to
issues
Nov 22, 2024
LoricAndre
force-pushed
the
feat/tmux-flag
branch
from
e78fb59 to
ed3a0ce
Compare
* Bump unicode-width from 0.1.14 to 0.2.0 (#616) Bumps [unicode-width](https://github.com/unicode-rs/unicode-width) from 0.1.14 to 0.2.0. - [Commits](unicode-rs/unicode-width@v0.1.14...v0.2.0) --- updated-dependencies: - dependency-name: unicode-width dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump nix from 0.25.1 to 0.29.0 (#614) Bumps [nix](https://github.com/nix-rust/nix) from 0.25.1 to 0.29.0. - [Changelog](https://github.com/nix-rust/nix/blob/master/CHANGELOG.md) - [Commits](nix-rust/nix@v0.25.1...v0.29.0) --- updated-dependencies: - dependency-name: nix dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump env_logger from 0.9.3 to 0.11.5 (#615) Bumps [env_logger](https://github.com/rust-cli/env_logger) from 0.9.3 to 0.11.5. - [Release notes](https://github.com/rust-cli/env_logger/releases) - [Changelog](https://github.com/rust-cli/env_logger/blob/main/CHANGELOG.md) - [Commits](rust-cli/env_logger@v0.9.3...v0.11.5) --- updated-dependencies: - dependency-name: env_logger dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: LoricAndre <[email protected]> * chore: improve PR ci * disable cache on fmt job * add title check * clean * Create pr.yml --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: LoricAndre <[email protected]>
LoricAndre
changed the title
--tmux flag (deprecates sk-tmux, fixes #596)--tmux flag (deprecates sk-tmux, fixes #596)
LoricAndre
force-pushed
the
master
branch
4 times, most recently
from
6b0fab9 to
e649d08
Compare
LoricAndre
changed the title
--tmux flag (deprecates sk-tmux, fixes #596)--tmux flag (deprecates sk-tmux, fixes #596)
This was referenced Nov 30, 2024
Merged
Merged
Merged
Merged
ibhagwan
added a commit
to ibhagwan/fzf-lua
that referenced
this pull request
Dec 4, 2024
|
@LoricAndre, FYI ibhagwan/fzf-lua@d9db3b6 added tmux support, all that's needed is to add the :FzfLua files fzf_opts.--tmux=center,40%,40% fzf_bin=skThe result: I did discover one issue with tmux integration regarding the customization of the bg color which doesn't cover the entrire tmux popup, for example: sk --height=100% --tmux center,40%,40% --color="bg:#ffcb8b"
Doing so with fzf yields: |
|
TYSM for being so quick to react ! |
No biggie as this is easily avoidable by not theming the background, just FYI. Good luck on the rewrite and ty for your hard work 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The e2e are pretty basic but they should let us check the most delicate edge cases together with the unit tests