Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Local UniswapV3 Markets #340

Merged
merged 5 commits into from
Apr 11, 2024
Merged

feat: Local UniswapV3 Markets #340

merged 5 commits into from
Apr 11, 2024

Conversation

davidterpay
Copy link
Contributor

No description provided.

@davidterpay davidterpay marked this pull request as ready for review April 10, 2024 21:37
aljo242
aljo242 reviewed Apr 10, 2024
View reviewed changes
oracle/constants/currency_pairs.go
DAI_ETH = pkgtypes.NewCurrencyPair("DAI", "ETH")
ETHENA_ETH = pkgtypes.NewCurrencyPair("ENA", "ETH")
ETHERFI_ETH = pkgtypes.NewCurrencyPair("ETHFI", "ETH")
HARRY_POTTER_OBAMA_SONIC_10_INU_ETH = pkgtypes.NewCurrencyPair("HARRY_POTTER_OBAMA_SONIC_10_INU", "ETH")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kek

@codecov Codecov
Copy link

codecov bot commented Apr 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 56.73%. Comparing base (416b49d) to head (98f2d5f).

❗ Current head 98f2d5f differs from pull request most recent head 75044eb. Consider uploading reports for the commit 75044eb to get more accurate results

Files Patch % Lines
cmd/slinky-config/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
- Coverage   56.80%   56.73%   -0.08%     
==========================================
  Files         227      227              
  Lines       10761    10756       -5     
==========================================
- Hits         6113     6102      -11     
- Misses       4136     4141       +5     
- Partials      512      513       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Eric-Warehime
Eric-Warehime approved these changes Apr 11, 2024
View reviewed changes
cmd/slinky-config/main.go
@@ -302,7 +315,7 @@ func init() {
&updateInterval,
"update-interval",
"",
500*time.Millisecond,
250*time.Millisecond,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a relatively small change, but in general I think we should avoid combining unrelated changes into PRs. It makes it more likely for people to miss them.
Updating the default price aggregation interval has nothing to do with adding uniswap markets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea agreed, this was meant to be a fix in previous PRs but got excluded.

@davidterpay davidterpay merged commit e51e6c2 into main Apr 11, 2024
13 checks passed
@zrbecker zrbecker deleted the terpay/uniswap-markets branch November 5, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Warehime Eric-Warehime Eric-Warehime approved these changes

@aljo242 aljo242 aljo242 approved these changes

@nivasan1 nivasan1 Awaiting requested review from nivasan1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidterpay @Eric-Warehime @aljo242