Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add list query #888

Merged
merged 9 commits into from
Jan 15, 2025
Merged

feat: add list query #888

merged 9 commits into from
Jan 15, 2025

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Jan 15, 2025

  • Add Markets query which returns a list from the state (rather than a map)
  • Bump cosmos-sdk to fix vulnerability check

@aljo242 aljo242 requested a review from a team as a code owner January 15, 2025 15:21
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.

Project coverage is 57.39%. Comparing base (40a9be0) to head (9b75160).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/marketmap/keeper/keeper.go 53.84% 4 Missing and 2 partials ⚠️
x/marketmap/keeper/query.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #888      +/-   ##
==========================================
+ Coverage   57.38%   57.39%   +0.01%     
==========================================
  Files         214      214              
  Lines       14822    14844      +22     
==========================================
+ Hits         8505     8520      +15     
- Misses       5704     5708       +4     
- Partials      613      616       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bigly

@aljo242 aljo242 merged commit 457eb5a into main Jan 15, 2025
16 checks passed
@aljo242 aljo242 deleted the feat/add-list-query branch January 15, 2025 20:04
aljo242 pushed a commit that referenced this pull request Jan 15, 2025
aljo242 pushed a commit that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants