bug: Don't fail ante handler on simulate tx with no fee #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Warehime
requested review from
davidterpay,
nivasan1 and
aljo242
as code owners
bpiv400
approved these changes
Jun 16, 2024
aljo242
approved these changes
Jun 16, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jun 16, 2024
(cherry picked from commit d2f4f3b)
Eric-Warehime
added a commit
that referenced
this pull request
Jun 16, 2024
(cherry picked from commit d2f4f3b) Co-authored-by: Eric Warehime <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't intend to deny simulate requests with no fee set, but the only way we previously tested it was with a valid fee, but gas=auto it seems.
I've tried to case around the simulate in the ante handler so that min gas price still gets set on the context, but we don't fail on no fee coins in the tx.