fix: allow for no bank balances in all simulations #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aljo242
commented
Aug 22, 2024
aljo242
commented
- Always use 0denom dummy fee value in simulation
- Add in calculated gas consumption amount to account for keeper codepaths that are not hit because of this (in sim only)
- add non-mocked bank keeper testing
- lint fixes due to version bump
aljo242
requested review from
Eric-Warehime,
technicallyty and
wesl-ee
as code owners
added 2 commits
August 22, 2024 16:14
aljo242
force-pushed
the
fix/bank-balances
branch
from
96bd7d2 to
9447315
Compare
swelf19
approved these changes
Aug 23, 2024
pr0n00gler
approved these changes
Aug 23, 2024
Eric-Warehime
approved these changes
Aug 23, 2024
|
One question. In a slack there was a discussion about non consensus breaking patch, but seems like all the games with a gas meter are consensus breaking. |
aljo242
force-pushed
the
fix/bank-balances
branch
from
6326c15 to
5811698
Compare
mergify bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
* init * recreate and fix bug * helper * ante tests * ok * fix via gas consume call during simulation * test * revert * lint fix * retract more * replace linter * set lint to what we use (cherry picked from commit f1f216e) # Conflicts: # x/feemarket/ante/expected_keepers.go # x/feemarket/ante/mocks/mock_bank_keeper.go # x/feemarket/ante/suite/suite.go # x/feemarket/post/fee_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.