feat: init custom fee antehandler and posthandler #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
November 15, 2023 10:59
aljo242
requested review from
keefertaylor,
davidterpay and
nivasan1
as code owners
aljo242
commented
Nov 15, 2023
added 14 commits
November 15, 2023 11:29
davidterpay
reviewed
Nov 28, 2023
davidterpay
reviewed
Nov 28, 2023
davidterpay
reviewed
Nov 28, 2023
davidterpay
reviewed
Nov 28, 2023
davidterpay
reviewed
Nov 28, 2023
davidterpay
reviewed
Nov 28, 2023
davidterpay
reviewed
Nov 28, 2023
davidterpay
reviewed
Nov 28, 2023
davidterpay
reviewed
Nov 28, 2023
Comment on lines
+198
to
+204
| if tc.ExpPass { | ||
| require.NoError(t, txErr) | ||
| require.NoError(t, handleErr) | ||
| require.NotNil(t, newCtx) | ||
|
|
||
| s.Ctx = newCtx | ||
| } else { |
There was a problem hiding this comment.
Do we want to do any validation on the sent amount? I know that this is technically going to be testing external code but ideally we check fee amount was deducted, and that the context priority was correctly set.
There was a problem hiding this comment.
So right now, all of these tests use a mock bank keeper, so the fees aren't really "sent". I figured we would do the validation of that in an e2e test, but we could also do it here.
wdyt?
There was a problem hiding this comment.
yea, im fine with e2e.
Co-authored-by: David Terpay <[email protected]>
Co-authored-by: David Terpay <[email protected]>
Co-authored-by: David Terpay <[email protected]>
davidterpay
reviewed
Nov 28, 2023
x/feemarket/post/fee.go
Outdated
| return ctx, errorsmod.Wrapf(err, "unable to get fee market state") | ||
| } | ||
|
|
||
| state.Window[state.Index] += gas |
There was a problem hiding this comment.
I would use state.Update since that has a safety check on block gas limit.
davidterpay
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FeeMarketKeeperinterfaceapp.goantepkganteandpostpackagesanteandpost