refactor: use chaintestutil for integration test setup
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
November 29, 2023 11:27
added 11 commits
December 5, 2023 10:51
aljo242
requested review from
davidterpay,
nivasan1 and
Eric-Warehime
as code owners
aljo242
commented
Dec 6, 2023
| BankKeeper bankkeeper.Keeper | ||
| DistrKeeper distrkeeper.Keeper | ||
| StakingKeeper *stakingkeeper.Keeper | ||
| testkeeper.TestKeepers |
There was a problem hiding this comment.
My general idea here is for you to create your own TestKeepers struct which extends the "base" testkeepers chaintestutil gives you (bank, auth, distr, staking, etc).
So, here, we are just extending it with the feemarket keeper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor out most logic found in
testutilsto new package: chaintestutil.NOTE: testing will fail because a local version of
chaintestutilis being used as the repo is currently privatetest-unitandtest-integrationrun locally