Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: denom resolver #53

Merged
merged 20 commits into from
May 14, 2024
Merged

feat: denom resolver #53

merged 20 commits into from
May 14, 2024

Conversation

aljo242
Copy link
Collaborator

@aljo242 aljo242 commented Jan 9, 2024

Adds the DenomResolver interface to the feemarket Keeper.

The keeper can accept this interface or have it be set, and use it to resolve any non-base denoms to the feemarket's given base denom.

@aljo242 aljo242 changed the base branch from main to chore/accept-1-denom January 9, 2024 17:51
@aljo242 aljo242 changed the base branch from chore/accept-1-denom to main January 12, 2024 16:19
@aljo242 aljo242 changed the base branch from main to chore/accept-1-denom January 12, 2024 16:20
@aljo242 aljo242 changed the base branch from chore/accept-1-denom to main January 12, 2024 16:35
@aljo242 aljo242 requested a review from davidterpay May 13, 2024 18:16
Copy link
Contributor

@Eric-Warehime Eric-Warehime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct. Will be useful to get e2e testing in order to show an example of this in a basic app.

@aljo242 aljo242 merged commit ab49856 into main May 14, 2024
7 checks passed
@aljo242 aljo242 deleted the feat/denom-resolver branch May 14, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants