refactored queries, ante/post handlers and DenomResolver #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljo242
reviewed
May 23, 2024
swelf19
requested review from
davidterpay,
nivasan1 and
Eric-Warehime
as code owners
aljo242
reviewed
May 29, 2024
aljo242
reviewed
May 29, 2024
| Short: "Query for the current feemarket base fee", | ||
| Args: cobra.NoArgs, | ||
| RunE: func(cmd *cobra.Command, _ []string) error { | ||
| Use: "gas-price", |
There was a problem hiding this comment.
We should also add a cli query for gas-prices
Co-authored-by: Alex Johnson <[email protected]>
Co-authored-by: Alex Johnson <[email protected]>
Co-authored-by: Alex Johnson <[email protected]>
Co-authored-by: Alex Johnson <[email protected]>
|
I also updated output format from $ neutrond q feemarket gas-price untrn
0.002500000000000000untrn$ neutrond q feemarket gas-prices
0.002500000000000000untrnto $ ./build/neutrond q feemarket gas-price untrn
price:
amount: "0.002500000000000000"
denom: untrnwdyt? |
aljo242
approved these changes
May 29, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 29, 2024
* refactored queries, ante/post handlers and DenomResolver * fixed tests * disabling Ante when params.enabled == false * renamed AllowedDenom -> ExtraDenoms. Renamed fee entities to gasprice * tiny fixes * reuse variable instaed of getting it by index * Update x/feemarket/fuzz/aimd_eip1559_test.go Co-authored-by: Alex Johnson <[email protected]> * Update x/feemarket/keeper/query_server.go Co-authored-by: Alex Johnson <[email protected]> * Update x/feemarket/keeper/query_server.go Co-authored-by: Alex Johnson <[email protected]> * Update x/feemarket/keeper/feemarket.go Co-authored-by: Alex Johnson <[email protected]> * some reviews fixes (fee -> gasPrice) * added cli query gas-prices. updated output format for gas-price(s) queries --------- Co-authored-by: Alex Johnson <[email protected]> (cherry picked from commit cf0c02f) # Conflicts: # tests/e2e/suite.go
aljo242
pushed a commit
that referenced
this pull request
May 29, 2024
* refactored queries, ante/post handlers and DenomResolver * fixed tests * disabling Ante when params.enabled == false * renamed AllowedDenom -> ExtraDenoms. Renamed fee entities to gasprice * tiny fixes * reuse variable instaed of getting it by index * Update x/feemarket/fuzz/aimd_eip1559_test.go Co-authored-by: Alex Johnson <[email protected]> * Update x/feemarket/keeper/query_server.go Co-authored-by: Alex Johnson <[email protected]> * Update x/feemarket/keeper/query_server.go Co-authored-by: Alex Johnson <[email protected]> * Update x/feemarket/keeper/feemarket.go Co-authored-by: Alex Johnson <[email protected]> * some reviews fixes (fee -> gasPrice) * added cli query gas-prices. updated output format for gas-price(s) queries --------- Co-authored-by: Alex Johnson <[email protected]> (cherry picked from commit cf0c02f) # Conflicts: # tests/e2e/suite.go Co-authored-by: swelf19 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DenomResolverinterface, the interface requires an additional methodExtraDenoms, the method should return a list of all denoms in which it is possible to pay fees. Used in GasPrices method to display gas prices for all currencies.ConvertToDenomDenomResolvermethod now works with DecCoin instead of Coin.GasPricewith a denom payload as argument. Returns a gas price for specified denomGasPriceswithout arguments. Returns a list of all gas prices (addetionel denoms come fromExtraDenomsmethod). Those can be used as fees