fix: simplify feemarket based on AIMD paper #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljo242
requested review from
davidterpay,
nivasan1 and
Eric-Warehime
as code owners
|
Core logic change looks good to me! seems like there's a few more places where the TargetBlockUtilization is still used. the places I found were Line 503 in e60dd4e Line 402 in e60dd4e feemarket/tests/e2e/e2e_test.go Line 63 in e60dd4e |
added 2 commits
June 4, 2024 10:40
davidterpay
approved these changes
Jun 4, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
* rename properly and add bounds * format proto * refactor * tip fe * bye target * func * fix * params * ante * bet * fix all (cherry picked from commit 7b6193a) # Conflicts: # tests/e2e/go.mod # tests/e2e/go.sum # tests/e2e/setup.go # tests/integration/integration_test.go # x/feemarket/ante/expected_keepers.go # x/feemarket/ante/suite/suite.go
aljo242
pushed a commit
that referenced
this pull request
Jun 4, 2024
* fix: simplify feemarket based on AIMD paper (#94) * rename properly and add bounds * format proto * refactor * tip fe * bye target * func * fix * params * ante * bet * fix all (cherry picked from commit 7b6193a) # Conflicts: # tests/e2e/go.mod # tests/e2e/go.sum # tests/e2e/setup.go # tests/integration/integration_test.go # x/feemarket/ante/expected_keepers.go # x/feemarket/ante/suite/suite.go * fix * ok * fix * fix --------- Co-authored-by: Alex Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
targetUtilizationparam (always 0.5 * maxUtilization)https://arxiv.org/pdf/2110.04753