feat: add types and util #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zygimantass
requested review from
davidterpay,
nivasan1,
aljo242 and
Eric-Warehime
as code owners
Zygimantass
force-pushed
the
zygis/add-util-and-types
branch
from
6e06cd8 to
5d0332f
Compare
nivasan1
approved these changes
Dec 22, 2023
.github/workflows/lint.yml
Outdated
| @@ -20,10 +20,13 @@ jobs: | |||
| with: | |||
| go-version: 1.21.3 | |||
| - uses: actions/checkout@v4 | |||
| - name: initialize workspace | |||
| run: | | |||
| go work init ||: | |||
There was a problem hiding this comment.
does the linter fail w/o workspace init?
| @@ -0,0 +1,3 @@ | |||
| module github.com/skip-mev/petri/util | |||
There was a problem hiding this comment.
Looks like for now there's no need to make this a submodule? All dependencies are stdlib. Maybe I'm missing smth tho
|
hmm... looks like linter is failing despite us initializing the workspace? Are we inserting the correct use directives? I.e |
feat: add chain package
feat: add node package
feat: add wallet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.