feat(chain): add chain serialization #164
Conversation
Zygimantass
force-pushed
the
zygis/chain-serialization
branch
from
e94051c to
38b3d17
Compare
Zygimantass
force-pushed
the
zygis/chain-serialization
branch
from
38b3d17 to
bd08ed6
Compare
nadim-az
changed the base branch from
release/v3.x.x
to
zygis/harden-docker-networking
| NodeOptions NodeOptions // NodeOptions is the options for creating a node | ||
| NodeCreator NodeCreator // NodeCreator is a function that creates a node | ||
|
|
||
| WalletConfig WalletConfig // WalletConfig is the default configuration of a chain's wallet |
There was a problem hiding this comment.
Should we mark the WalletConfig option as required and validate its not nil during config validation? During my DO provider testing, I ran into an error when I tried to create a chain without WalletConfig set, but we currently dont do any validation for it
There was a problem hiding this comment.
Or alternatively add default config
| @@ -20,28 +23,31 @@ const idAlphabet = "abcdefghijklqmnoqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ12345678 | |||
| var defaultChainConfig = types.ChainConfig{ | |||
| Denom: "stake", | |||
| Decimals: 6, | |||
| NumValidators: 1, | |||
| NumValidators: 4, | |||
| NumNodes: 0, | |||
| BinaryName: "/simd/simd", | |||
| Image: provider.ImageDefinition{ | |||
| Image: "cosmossdk/simd:latest", | |||
There was a problem hiding this comment.
is this image publicly available or just cached on your machine? im not able to pull this or find it in the docker hub
There was a problem hiding this comment.
good shout, will replace it
| @@ -121,9 +125,5 @@ func (c *ChainConfig) ValidateBasic() error { | |||
| return fmt.Errorf("chain ID cannot be empty") | |||
| } | |||
|
|
|||
| if c.NodeCreator == nil { | |||
There was a problem hiding this comment.
Why was this removed? this option is still required afaiu
There was a problem hiding this comment.
should validation be added elsewhere then for the required opts fields?
|
Are all of the A problem we ran into with connect is that we started falling in love with this |
No description provided.