hide diff percentage when usd 0

skip-mev · Apr 16, 2024 · 4ee73f8 · 4ee73f8
1 parent d224f29
commit 4ee73f8
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/src/components/AssetInput.tsx b/src/components/AssetInput.tsx
@@ -178,8 +178,10 @@ function AssetInput({
           }}
         />
         <div className="flex h-8 items-center space-x-2 tabular-nums">
-          <p className="text-sm tabular-nums text-neutral-400">{amountUSD ? formatUSD(amountUSD) : null}</p>
-          {amountUSD !== undefined && diffPercentage !== 0 && context === "destination" ? (
+          <p className="text-sm tabular-nums text-neutral-400">
+            {amountUSD && Number(amountUSD) > 0 ? formatUSD(amountUSD) : null}
+          </p>
+          {amountUSD !== undefined && Number(amountUSD) > 0 && diffPercentage !== 0 && context === "destination" ? (
             <p className={cn("text-sm tabular-nums", diffPercentage >= 0 ? "text-green-500" : "text-red-500")}>
               ({formatPercent(diffPercentage)})
             </p>

diff --git a/src/components/SwapWidget/SwapWidget.tsx b/src/components/SwapWidget/SwapWidget.tsx
@@ -62,13 +62,9 @@ export function SwapWidget() {
     sourceFeeAmount,
     sourceFeeAsset,
     swapPriceImpactPercent,
+    usdDiffPercent,
   } = useSwapWidget();
 
-  let usdDiffPercent = 0.0;
-  if (route?.usdAmountIn && route?.usdAmountOut) {
-    usdDiffPercent = (parseFloat(route.usdAmountOut) - parseFloat(route.usdAmountIn)) / parseFloat(route.usdAmountIn);
-  }
-
   const srcAccount = useAccount("source");
   const destAccount = useAccount("destination");
 

diff --git a/src/components/SwapWidget/useSwapWidget.ts b/src/components/SwapWidget/useSwapWidget.ts
@@ -183,8 +183,12 @@ export function useSwapWidget() {
     if (!route) {
       return undefined;
     }
-
-    if (!route.usdAmountIn || !route.usdAmountOut) {
+    if (
+      !route.usdAmountIn ||
+      !route.usdAmountOut ||
+      Number(route.usdAmountIn) === 0 ||
+      Number(route.usdAmountOut) === 0
+    ) {
       return undefined;
     }
 
@@ -831,6 +835,7 @@ export function useSwapWidget() {
     sourceFeeAmount: gasRequired,
     sourceFeeAsset: srcFeeAsset,
     swapPriceImpactPercent,
+    usdDiffPercent,
   };
 }