Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display warning on high price impact #130

Merged
merged 5 commits into from
Dec 28, 2023
Merged

Display warning on high price impact #130

merged 5 commits into from
Dec 28, 2023

Conversation

thal0x
Copy link
Member

@thal0x thal0x commented Dec 26, 2023

Updates ibc.fun to:

  • Use USD values from the API
  • Display price impact in the SwapDetails component
  • If price impact is higher than a configurable threshold (I set to 1%, let me know what you'd actually like it to be):
    • Open the SwapDetails accordion to highlight the high price impact
    • Display a warning popup before submitting any transactions
price-impact-warning.mov

@thal0x thal0x self-assigned this Dec 26, 2023
Copy link

vercel bot commented Dec 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ibc-dot-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2023 2:56pm

@thal0x thal0x marked this pull request as ready for review December 26, 2023 13:17
@bpiv400 bpiv400 merged commit 41fcac7 into staging Dec 28, 2023
3 checks passed
@grikomsn grikomsn deleted the jw/price-warning branch January 1, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants