Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump widget version #334

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Bump widget version #334

merged 4 commits into from
Jul 18, 2024

Conversation

codingki
Copy link
Member

No description provided.

@codingki codingki requested review from toddkao and NotJeremyLiu July 18, 2024 16:37
@codingki codingki requested a review from bpiv400 as a code owner July 18, 2024 16:37
@vercel Vercel
Copy link

vercel bot commented Jul 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ibc-dot-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 5:48pm

toddkao
toddkao requested changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@toddkao toddkao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add static height/width to the container element? otherwise there's some layout shift

@codingki
Copy link
Member Author

Can we add static height/width to the container element? otherwise there's some layout shift

sure

@codingki codingki mentioned this pull request Jul 18, 2024
Closed
@codingki codingki merged commit d46c487 into staging Jul 18, 2024
2 checks passed
@toddkao toddkao deleted the bump-widget-version branch July 18, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddkao toddkao toddkao approved these changes

@NotJeremyLiu NotJeremyLiu Awaiting requested review from NotJeremyLiu

@bpiv400 bpiv400 Awaiting requested review from bpiv400

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codingki @toddkao