[SPE-246] Add support for EVM wallets, separate source and destination wallets #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thal0x
commented
Sep 28, 2023
| "@wagmi/core", | ||
| "@wagmi/connectors", | ||
| "viem", | ||
| "abitype", |
There was a problem hiding this comment.
This is all just due to weird CJS vs ESM interactions when running Jest. I think I'm going to add a task to migrate to vitest since it doesn't have these problems and I've had a good experience with it in the skip-router repo
thal0x
changed the title
grikomsn
approved these changes
Oct 16, 2023
src/solve/context.tsx
Outdated
| @@ -18,7 +18,7 @@ export const SkipContext = createContext< | |||
| export const SkipProvider: FC<PropsWithChildren> = ({ children }) => { | |||
| const { client: walletClient } = useWalletClient(); | |||
|
|
|||
| const skipClient = new SkipRouter(SKIP_API_URL, { | |||
| const skipClient = new SkipRouter("https://solve-dev.skip.money", { | |||
There was a problem hiding this comment.
Thoughts on moving to env based vars?
Remove Chain context
Finish evm integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not address: getting EVM asset balances, making EVM transactions, anything other than connecting your wallet.