Skip to content

Commit

Permalink
Return Avro objects if implemented instead of String to make producer…
Browse files Browse the repository at this point in the history
…s working with Schema Registry (#34)

## Description

Current implementation returns only String which cannot work with Schema
Registry. This PR returns Object that allows producers to make it
working with Avro.

## Type of Change

* Bug fix (non-breaking change which fixes an issue)

## Checklist

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas

Signed-off-by: Jakub Stejskal <[email protected]>
  • Loading branch information
Frawless authored Sep 12, 2024
1 parent 8fcc42d commit 9677a0d
Show file tree
Hide file tree
Showing 7 changed files with 20 additions and 20 deletions.
4 changes: 2 additions & 2 deletions src/main/java/io/skodjob/datagenerator/DataGenerator.java
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public DataGenerator(ETemplateType templateType) {
*
* @return the generated string data
*/
public String generateData() {
public Object generateData() {
switch (this.templateType) {
case PAYROLL:
return PayrollHandler.generateData();
Expand All @@ -67,7 +67,7 @@ public String generateData() {
*/
public JsonNode generateJsonData() {
try {
return new ObjectMapper().readTree(generateData());
return new ObjectMapper().readTree(generateData().toString());
} catch (Exception e) {
throw new RuntimeException("Error generating JSON data", e);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ private FlightsHandler() {
/**
* Generates flight data using the Faker library.
*
* @return the generated flight data as a JSON string
* @return the generated flight data as an Avro Object
*/
public static String generateData() {
public static Object generateData() {
FlightRecord flightRecord = new FlightRecord();

Passenger passenger = new Passenger();
Expand All @@ -62,6 +62,6 @@ public static String generateData() {
flightRecord.setPassenger(passenger);
flightRecord.setFlight(flight);

return flightRecord.toString();
return flightRecord;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ private static String generateActivityState() {
/**
* Generates IoT device data using the Faker library.
*
* @return the generated IoT device data as a JSON string
* @return the generated IoT device data as an Avro Object
*/
public static String generateData() {
public static Object generateData() {
IotDevice iotDevice = new IotDevice();

iotDevice.setIPV4(FAKER.internet().ipV4Address());
Expand Down Expand Up @@ -148,6 +148,6 @@ public static String generateData() {
break;
}

return iotDevice.toString();
return iotDevice;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,11 @@ private static PaymentFiat generatePaymentFiatData() {
/**
* Generates payment data using the Faker library.
*
* @return the generated payment data as a JSON string
* @return the generated payment data as an Avro Object
*/
public static String generateData() {
public static Object generateData() {
PaymentFiat paymentFiat = generatePaymentFiatData();

return paymentFiat.toString();
return paymentFiat;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ private PayrollHandler() {
/**
* Generates payroll employee data using the Faker library.
*
* @return the generated payroll employee data as a JSON string
* @return the generated payroll employee data as an Avro Object
*/
public static String generateData() {
public static Object generateData() {
Employee employee = new Employee();

employee.setEmployeeId(String.valueOf(FAKER.number().numberBetween(10000, 999999)));
Expand All @@ -44,6 +44,6 @@ public static String generateData() {
employee.setEmail(FAKER.internet().emailAddress());
employee.setCompany(FAKER.company().name());

return employee.toString();
return employee;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ private StarGateHandler() {
/**
* Generates StarGate data using the Faker library.
*
* @return the generated StarGate data as a JSON string
* @return the generated StarGate data as an Avro Object
*/
public static String generateData() {
public static Object generateData() {
StarGate starGate = new StarGate();
starGate.setCharacterName(FAKER.stargate().characters());
starGate.setSourcePlanet(FAKER.stargate().planets());
Expand All @@ -42,6 +42,6 @@ public static String generateData() {
starGate.setDistance(FAKER.number().numberBetween(20000, 999999));
starGate.setDistanceUnit("light_year");

return starGate.toString();
return starGate;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ private StarWarsHandler() {
/**
* Generates StarWars data using the Faker library.
*
* @return the generated StarWars data as a JSON string
* @return the generated StarWars data as an Avro Object
*/
public static String generateData() {
public static Object generateData() {
StarWars starWars = new StarWars();
starWars.setCharacterName(FAKER.starWars().character());
starWars.setSourcePlanet(FAKER.starWars().planets());
Expand All @@ -43,6 +43,6 @@ public static String generateData() {
starWars.setWookieWords(FAKER.starWars().wookieWords());
starWars.setAlternateCharacterSpelling(FAKER.starWars().alternateCharacterSpelling());

return starWars.toString();
return starWars;
}
}

0 comments on commit 9677a0d

Please sign in to comment.