-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Added Inverse Gamma distribution #415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we´ll need these for the conjugates.
Can you kindly also add these to the API reference?
docs/source/api_reference
also, you will need to update your fork from |
Sure! I've added the two distributions to the API reference and resolved the merged conflicts |
Yes, this is expected given the current implementation but also a bug. Could you kindly open an issue and link your example and add my comments below? Currently, the plotting function sampes a grid of x points, plots x, f(x) for the function and connects them. If the grid does not hit the mass points, the plot will look like this. The only way to have the correct plot always is to know where the support is. That is currenty not inspectable from the object, and that's why I wanted the sets symbolism from #244.. Speaking of which, do you have an ETA for the next iteration, or are you no longer working on this, @VascoSch92? Any response is fine, just for planning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import in docstring example fails due to wrong module name
Sorry about that - have fixed the docstring typo |
Also, have opened a new issue about the plot pmf bug #416 |
Reference Issues/PRs
Related to the development of BayesianLinearRegression class. (#358)
What does this implement/fix? Explain your changes.
This pull request implements the Inverse Gamma distribution and Beta Distribution as a new distribution class.
The Inverse Gamma implementation wraps around
scipy.stats.invgamma
to provide functionalities consistent with other distributions in the library. I introduced this distribution as the conjugate prior for the variance (σ²) of a Normal distribution for subsequent use in theBayesianLinearRegression
class. (#358)Does your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
Correctness of implementation
Did you add any tests for the change?
No
Any other comments?
No
For all contributions
How to: add yourself to the all-contributors file in the
skpro
root directory (not theCONTRIBUTORS.md
). Common badges:code
- fixing a bug, or adding code logic.doc
- writing or improving documentation or docstrings.bug
- reporting or diagnosing a bug (get this pluscode
if you also fixed the bug in the PR).maintenance
- CI, test framework, release.See here for full badge reference
For new estimators
docs/source/api_reference/taskname.rst
, follow the pattern.Examples
section.python_dependencies
tag and ensureddependency isolation, see the estimator dependencies guide.