FP hists in broker mode: don't send unsaved #287
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have logic here in Kowalski to only save the
fp_hists
of new objects. This is to deal with the fact that forced photometry in the alerts is a somewhat recent addition, and we don't want to start accumulating it for older objects, but only new objects where the forced photometry 30-day window might give us detections that pre-date the first alert (and that theprv_candidates
would not have).However, with the current logic we do not flush/empty the fp_hists variable when it's not saved to the DB, so we end up sending to SkyPortal alert-based FP that we don't save in Kowalski. Though it doesn't make the photometry we send less correct, it's confusing more than anything else.
Here, we make sure to drop the
fp_hists
before sending it to SkyPortal unless it is saved in Kowalski beforehand.