bucket_name: add new variable bucket_name #4
Conversation
|
Hello @gaelL, Your contribution is much appreciated. However, to have the README.md in sync with the implementation, can you extend the docs (examples + variable description) to reflect your changes? Tnx. |
|
Sorry it was expected to be an internal PR. If you are interested by this change, I will update the readme as well. Thx |
|
@gaelL please do and I will integrate it in the repo here. |
gaelL
changed the title
|
done. I also add more information in the commit message |
Add a way to specify the bucket name to create for the static website. With this commit, we are now able to give a custom nice that match your personal naming convention. /!\ Remove the default behavior who name as site.$domain
| @@ -3,6 +3,7 @@ variable region { | |||
| } | |||
|
|
|||
| variable domain {} | |||
| variable bucket_name {} | |||
There was a problem hiding this comment.
Can you make the module backwards compatible by setting the default value of the bucket_name to the calculated value it was before?
"site.${replace("${var.domain}",".","-")}"
There was a problem hiding this comment.
In fact no, I tried but terraform can't have interpolation in default variable
This variable is here to be able to force the bucket name.
Remove the default behavior who name as site.$domain