Fix: use delayed write flash page in AvrIspProtocol #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This MR is about fixing the AvrIspProtocol.write_flash_page() by using the delayed write command with an optional delay parameter. A delayed write page flash is prefered over normal write command in terms of being in sync with MCU's flash memory timing constraints. See this issue for further details : microchip-pic-avr-tools/pymcuprog#44
araqioui
force-pushed
the
fix/delay-wirte-flash-page-isp
branch
from
8665fbe to
5fba457
Compare
BenjaminVincentSmade
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR is about fixing the AvrIspProtocol.write_flash_page() by using the delayed write command with an optional delay parameter. A delayed write page flash is prefered over normal write command in terms of being in sync with MCU's flash memory timing constraints.
See this issue for further details on implementation : microchip-pic-avr-tools/pymcuprog#44