Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Bump MP-OpenTracing to 2.0 and OT to 0.33.0 #138

Merged
merged 1 commit into from
Aug 8, 2020

Conversation

pavolloffay
Copy link
Contributor

Resolves #85
Depends on microprofile/microprofile-opentracing#191

The tests pass fine locally.

@pavolloffay
Copy link
Contributor Author

@radcortez MicroProfile-OpenTracing 2.0-RC1 has been released to master, hence the CI for this patch should pass.

Should we merge this or wait for the final artifacts?

@pavolloffay pavolloffay marked this pull request as ready for review July 14, 2020 13:27
@pavolloffay pavolloffay requested a review from radcortez July 14, 2020 13:28
@pavolloffay
Copy link
Contributor Author

cc) @radcortez

@Ladicek
Copy link
Contributor

Ladicek commented Jul 27, 2020

I think we can merge as is, but most likely shouldn't release (unless the release itself is an alpha/beta/candidate or something like that).

Ladicek
Ladicek previously approved these changes Jul 27, 2020
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update OpenTracing to 0.33.0
3 participants