chore: simpler ber2der with length check #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not build an intermediate tree presentation of BER format in ber2der. Rather write the data directly to the output array patching the length header as necessary. Protect against int32 overflow on 32-bit CPU when calculating the BER content length. Detect and report invalid BER when a fixed length of the sequence does not match the actual length of children.
|
Hey @ibukanov, thank you for working on this. This looks like a great improvement! I need some time to grok it all for proper review 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not build an intermediate tree presentation of BER format in ber2der. Rather write the data directly to the output array patching the length header as necessary.
Protect against int32 overflow on 32-bit CPU when calculating the BER content length.
Detect and report invalid BER when a fixed length of the sequence does not match the actual length of children.
Name of feature:
Stricter definite length handling in BER data.
Pain or issue this feature alleviates:
Invalid BER data generator can be detected.
Why is this important to the project (if not answered above):
Is there documentation on how to use this feature? If so, where?
In what environments or workflows is this feature supported?
In what environments or workflows is this feature explicitly NOT supported (if any)?
Supporting links/other PRs/issues:
💔Thank you!