Add Explicit Names For CI #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krebernisak
previously approved these changes
Mar 29, 2022
fix go lint to not be ignored for required checks
krebernisak
requested changes
Mar 30, 2022
aalu1418
requested changes
Apr 1, 2022
aalu1418
previously approved these changes
Apr 1, 2022
aalu1418
approved these changes
Apr 4, 2022
krebernisak
approved these changes
Apr 5, 2022
| @@ -37,7 +37,7 @@ linters-settings: | |||
| - name: error-return | |||
| - name: error-strings | |||
| - name: error-naming | |||
| - name: exported | |||
| # - name: exported | |||
There was a problem hiding this comment.
We should document all Go exported (public) types
akhilchainani
pushed a commit
that referenced
this pull request
Apr 6, 2022
* Update names for ci jobs * update naming to be lowercase snakecase fix go lint to not be ignored for required checks * cleanup npm token * Clean up chaos github action to use nix and add golint to asdf and make * bump versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.