Horizontally positioning coolSliderControl #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vertical position of the slider required scrolling when making adjustments to temperature since the height of the slider was greater than the usable viewport. Positioning the slider horizontally improves usability by containing the slider within the usable viewport.
|
Just noticed that imbrianj had actually committed the change that my change reverts because of slider issues in Android. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vertical position of the slider requires the user to scroll when making adjustments to temperature since the height of the slider was greater than the usable viewport. Positioning the slider horizontally improves usability by containing the slider within the usable viewport.