Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add timsTOF support to MetaMorpeus #2462

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

Alexander-Sol
Copy link
Contributor

@Alexander-Sol Alexander-Sol commented Jan 30, 2025

Calibration and quant aren't currently supported, and will be quietly disabled or skipped if the user tries to quantify/calibrate a timsTOF data file.

Search and GPTMD will work and are supported

@Alexander-Sol Alexander-Sol changed the title [WIP] Tims tof Added timsTOF support to MetaMorpeus Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.93%. Comparing base (8210576) to head (6b00ecf).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2462   +/-   ##
=======================================
  Coverage   93.93%   93.93%           
=======================================
  Files         148      148           
  Lines       22455    22464    +9     
  Branches     3082     3084    +2     
=======================================
+ Hits        21093    21102    +9     
  Misses        911      911           
  Partials      451      451           
Files with missing lines Coverage Δ
...pheus/TaskLayer/CalibrationTask/CalibrationTask.cs 89.14% <100.00%> (+0.40%) ⬆️
MetaMorpheus/TaskLayer/SearchTask/SearchTask.cs 95.93% <100.00%> (+<0.01%) ⬆️

Copy link
Member

@nbollis nbollis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a project reference to sqlite in CMD, EngineLayer, and GUI but not TaskLayer and Test?

@Alexander-Sol
Copy link
Contributor Author

Sql dependencies are required in CMD, EngineLayer, TaskLayer, and GUI for installed versions of MM to work properly

Test project isn't installed, so they don't need to be bundled

@Alexander-Sol Alexander-Sol added WIP Work in progress, not ready for review and removed ready for review labels Feb 4, 2025
@Alexander-Sol Alexander-Sol changed the title Added timsTOF support to MetaMorpeus [WIP] Add timsTOF support to MetaMorpeus Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature WIP Work in progress, not ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants