Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model lock #2463

Merged
merged 6 commits into from
Feb 4, 2025
Merged

Model lock #2463

merged 6 commits into from
Feb 4, 2025

Conversation

Alexander-Sol
Copy link
Contributor

@Alexander-Sol Alexander-Sol commented Jan 31, 2025

In the PEP analysis engine, multiple threads need to read in the stored model. Currently, no lock is activated during reading, which can result in multiple threads reading the model simultaneously, resulting in a crash.

I'm not sure how to write unit tests for lock objects, so I was hoping we could let this one get through with low patch coverage

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.91%. Comparing base (3b41e64) to head (15ede0d).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2463      +/-   ##
==========================================
+ Coverage   93.89%   93.91%   +0.01%     
==========================================
  Files         146      146              
  Lines       22206    22207       +1     
  Branches     3059     3059              
==========================================
+ Hits        20851    20856       +5     
+ Misses        906      903       -3     
+ Partials      449      448       -1     
Files with missing lines Coverage Δ
...pheus/EngineLayer/FdrAnalysis/PEPAnalysisEngine.cs 95.47% <100.00%> (+0.52%) ⬆️

@nbollis nbollis merged commit 191d39a into smith-chem-wisc:master Feb 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants