Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made updates pertaining to PIP-ECHO #2468

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Alexander-Sol
Copy link
Contributor

The current version of mzLib has had some significant changes made to MBR in FlashLFQ.

This update supports those changes.

  • Added property to SearchParameters - MbrFdrThreshold. This controls the FDR of MBR identifications

    • Added text box in Search Task to allow users to set this parameter
  • Call to the FlashLFQ engine in PostSearchAnalysisTask receives additional argument - PeptidesToQuantify

    • This ensures that only peptides with a peptide-level Q-value <0.01 are written to the output and used to calculate protein intensities
  • Identifications passed in to FlashLFQ now have additional information: Score, Q-value, and bool isDecoy.

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.95%. Comparing base (9766001) to head (2e2cf5d).

Files with missing lines Patch % Lines
...eus/TaskLayer/SearchTask/PostSearchAnalysisTask.cs 95.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2468      +/-   ##
==========================================
+ Coverage   93.93%   93.95%   +0.01%     
==========================================
  Files         149      149              
  Lines       22474    22497      +23     
  Branches     3090     3093       +3     
==========================================
+ Hits        21111    21137      +26     
+ Misses        911      908       -3     
  Partials      452      452              
Files with missing lines Coverage Δ
MetaMorpheus/TaskLayer/FilteredPsms.cs 96.84% <100.00%> (+0.03%) ⬆️
...aMorpheus/TaskLayer/SearchTask/SearchParameters.cs 100.00% <100.00%> (ø)
...eus/TaskLayer/SearchTask/PostSearchAnalysisTask.cs 94.15% <95.83%> (+0.27%) ⬆️


<local:DoubleTextBoxControl x:Name="MbrFdrThresholdTextBox" Width="45" Height="20">
<ToolTipService.ToolTip>
<ToolTip Content="FDR Threshold for MBR Results" ToolTipService.ShowDuration="999999" ToolTipService.InitialShowDelay="500" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should say that this is the q-value cut-off to select peptides used for label free quant. Could say that there may be some PSMs with q-value below cut-off that from peptides at greater than q-value cut-off and these will not be quantified. Also, all psms with q-value below cut-off will be used to mark a peptide as MSMS identified

Copy link
Contributor Author

@Alexander-Sol Alexander-Sol Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should say that this is the q-value cut-off to select peptides used for label free quant.

This controls the q-value for PIP, determining which PIP Events/MBR transfers are reported in the AllQuantifiedPeptides/ProteinGroups output. I've updated the text to make this more clear

nbollis
nbollis previously approved these changes Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants