-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made updates pertaining to PIP-ECHO #2468
base: master
Are you sure you want to change the base?
Made updates pertaining to PIP-ECHO #2468
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2468 +/- ##
==========================================
+ Coverage 93.93% 93.95% +0.01%
==========================================
Files 149 149
Lines 22474 22497 +23
Branches 3090 3093 +3
==========================================
+ Hits 21111 21137 +26
+ Misses 911 908 -3
Partials 452 452
|
|
||
<local:DoubleTextBoxControl x:Name="MbrFdrThresholdTextBox" Width="45" Height="20"> | ||
<ToolTipService.ToolTip> | ||
<ToolTip Content="FDR Threshold for MBR Results" ToolTipService.ShowDuration="999999" ToolTipService.InitialShowDelay="500" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should say that this is the q-value cut-off to select peptides used for label free quant. Could say that there may be some PSMs with q-value below cut-off that from peptides at greater than q-value cut-off and these will not be quantified. Also, all psms with q-value below cut-off will be used to mark a peptide as MSMS identified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should say that this is the q-value cut-off to select peptides used for label free quant.
This controls the q-value for PIP, determining which PIP Events/MBR transfers are reported in the AllQuantifiedPeptides/ProteinGroups output. I've updated the text to make this more clear
The current version of mzLib has had some significant changes made to MBR in FlashLFQ.
This update supports those changes.
Added property to SearchParameters - MbrFdrThreshold. This controls the FDR of MBR identifications
Call to the FlashLFQ engine in PostSearchAnalysisTask receives additional argument - PeptidesToQuantify
Identifications passed in to FlashLFQ now have additional information: Score, Q-value, and bool isDecoy.