Db writer fix #820
Merged
Db writer fix #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #820 +/- ##
==========================================
+ Coverage 77.26% 77.28% +0.01%
==========================================
Files 218 218
Lines 33027 33037 +10
Branches 3426 3426
==========================================
+ Hits 25519 25531 +12
+ Misses 6938 6937 -1
+ Partials 570 569 -1
|
nbollis
previously approved these changes
Jan 7, 2025
RayMSMS
approved these changes
Jan 9, 2025
nbollis
approved these changes
Jan 9, 2025
zhuoxinshi
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing an XML protein database displays non-deterministic behavior. HashSets (which are inherently unordered) of Modifications are enumerated and the results written to the database one at a time. This can result in the database listing mods in different orders if the write operation is performed multiple times.
This PR fixes the order in which mods are written to the database, with the end goal of improving stability within MetaMorpheus.