Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed rounding method #826

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

Alexander-Sol
Copy link
Contributor

As it turns out, there is a very good reason that Math.Round() uses MidpointRounding.RoundToEven as the default method of rounding. For more information, see here:n https://learn.microsoft.com/en-us/dotnet/api/system.math.round?view=net-9.0

This PR amends the mzML writer rounding PR (#821) to use the default rounding method.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.76%. Comparing base (de68239) to head (b9ae8f1).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #826   +/-   ##
=======================================
  Coverage   77.76%   77.76%           
=======================================
  Files         230      230           
  Lines       34166    34166           
  Branches     3540     3540           
=======================================
  Hits        26569    26569           
  Misses       6991     6991           
  Partials      606      606           
Files with missing lines Coverage Δ
mzLib/MassSpectrometry/MzSpectra/MzSpectrum.cs 91.38% <100.00%> (ø)

Copy link
Contributor

@trishorts trishorts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some itraq failures.

@nbollis
Copy link
Member

nbollis commented Jan 22, 2025

some itraq failures.

Those are my bad. They are fixed by my PR

@nbollis nbollis merged commit 5d2b774 into smith-chem-wisc:master Jan 22, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants