Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): fix imports for aws-sdk shapes #777

Open
wants to merge 5 commits into
base: main-1.x
Choose a base branch
from

Conversation

rishav-karanjit
Copy link
Member

@rishav-karanjit rishav-karanjit commented Jan 29, 2025

Issue #, if available:

Description of changes:

  • We always import "github.com/aws/aws-sdk-go-v2/service/dynamodb/types" but not "github.com/aws/aws-sdk-go-v2/service/dynamodb". This PR fixes it.

Highlighting changes to make PR review easy:

  • File which adds a new function for imports:
    codegen/smithy-dafny-codegen/src/main/java/software/amazon/polymorph/smithygo/utils/GoCodegenUtils.java
  • Rest all the diff are just about calling the function.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rishav-karanjit rishav-karanjit marked this pull request as ready for review January 29, 2025 20:26
@rishav-karanjit rishav-karanjit requested a review from a team as a code owner January 29, 2025 20:26
@rishav-karanjit rishav-karanjit changed the title fix(go): Add missing import for aws-sdk shapes fix(go): fix imports for aws-sdk shapes Jan 29, 2025
Copy link
Member Author

@rishav-karanjit rishav-karanjit Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff in this file adds a function to import AWS SDK Shape. Rest of the diff is just about calling this function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant