Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing setters to ConfigLoader #4027

Merged
merged 5 commits into from
Feb 21, 2025
Merged

Conversation

landonxjames
Copy link
Contributor

Motivation and Context

Customer reported that the request_checksum_calculation and response_checksum_validation setters were missing from the ConfigLoader, but were present on the SdkConfig builder. This PR adds those setters.

Description

Testing

Checklist

  • For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "aws-sdk-rust" in the applies_to key.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@landonxjames landonxjames marked this pull request as ready for review February 20, 2025 06:17
@landonxjames landonxjames requested review from a team as code owners February 20, 2025 06:17
@landonxjames landonxjames added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2025
@landonxjames landonxjames added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit bb92aef Feb 21, 2025
43 of 45 checks passed
@landonxjames landonxjames deleted the landonxjames/configupdate branch February 21, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants