Fix TSApplicationGenerator
to use Result<>
instead of #{Result}
#4031
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The earlier PR, which ensured that a Smithy shape named
Result
does not conflict with the Rust typeResult
, had a bug inTSApplicationGenerator
. TherustTemplateBlock
was using#{Result}
butpreludeScope
was not passed in as a parameter.This bug can be addressed in two ways:
*RuntimeType.preludeScope
to therustBlockTemplate
call#{Result}
fromrustBlockTemplate
and continue usingResult<>
This PR implements the second approach because:
TSApplicationGenerator
is slated for deprecationCI / PR Bot / Generate diff and upload to S3 (pull_request)
currently fails when comparing codegen between HEAD and this version. Removing#{Result}
is the most reliable way to avoid parameter-passing issues withrustBlockTemplate