feat(experimentalIdentityAndAuth): add internal error and success handlers to HttpSigner and QOL changes
#1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
force-pushed
the
ts-ia-core-ts-changes
branch
2 times, most recently
from
0bc836e to
3a1f05b
Compare
syall
changed the title
HttpSigner and QOL changes
syall
force-pushed
the
ts-ia-core-ts-changes
branch
from
3a1f05b to
02fc3b8
Compare
kuhe
reviewed
Nov 21, 2023
kuhe
reviewed
Nov 21, 2023
| * @internal | ||
| */ | ||
| export interface SuccessHandler { | ||
| (httpResponse: HttpResponse | unknown, signingProperties: Record<string, unknown>): void; |
There was a problem hiding this comment.
signingProperties should have a type. It can be a record too (&), but it should also indicate that it tends to have properties like name, in, etc.
There was a problem hiding this comment.
This is the generic HttpSigner which has no context for the properties of any specific HttpAuthScheme.
I think specific concrete implementations of HttpSigner can provide more type hints, but I can add that in a follow-up PR.
AndrewFossAWS
approved these changes
Nov 21, 2023
syall
force-pushed
the
ts-ia-core-ts-changes
branch
from
02fc3b8 to
2b09607
Compare
kuhe
approved these changes
Nov 21, 2023
sugmanue
pushed a commit
to sugmanue/smithy-typescript
that referenced
this pull request
Mar 4, 2024
* chore: prettify smithy-client * chore: prettier-ignore months array * chore: fixes for issues happened during precommit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A.
Description of changes:
Add internal error and success handlers to
HttpSignerforexperimentalIdentityAndAuth.Also add some quality of life improvements:
getSmithyContext()andnormalizeProvider()to@smithy/coreIf one or more of the packages in the
/packagesdirectory has been modified, be sureyarn changeset addhas been run and its output hasbeen committed and included in this pull request. See CONTRIBUTING.md.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.