fix(smithy-client): instanceof support for ServiceException class #1490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Internal JS-5478, Internal JS-5642
Description of changes:
adds proper support for the
instanceof
operator to ServiceException while ensuring subclasses maintain strict prototype checking.adds
[Symbol.hasInstance]
to ServiceException that supportsinstanceof
checks according to the assertion table noted below (in the comments).fixes prototype chain setup in ServiceException constructor to properly support inheritance.
this resolves an issue where duck-typed objects were incorrectly matching subclass
instanceof
checks (e.g.dummyServiceException instanceof NoSuchKey
would return true even when it wasn't actually a NoSuchKey instance).Testing
for
smithy-client
:If one or more of the packages in the
/packages
directory has been modified, be sureyarn changeset add
has been run and its output hasbeen committed and included in this pull request. See CONTRIBUTING.md.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.