Fix showteam in replays
#2164
Merged
Fix showteam in replays
#2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karthik99999
changed the title
showteam protocol in BattleLogshowteam in replays
mia-pi-git
pushed a commit
to mia-pi-git/pokemon-showdown-client
that referenced
this pull request
Oct 24, 2023
Zarel
reviewed
Nov 4, 2023
| @@ -3325,6 +3325,256 @@ export class Battle { | |||
| } as any; | |||
| } | |||
|
|
|||
| // Taken from Storage, they need to be implemented here so `showteam` can work | |||
There was a problem hiding this comment.
Hm, I think it's best not to duplicate this code.
There was a problem hiding this comment.
Centralizing in battle-dex.ts makes sense. It'd be loaded before Storage.
Zarel
added a commit
that referenced
this pull request
Nov 4, 2023
PR #2164 added duplicate copies of these functions to battle.ts which is already quite overloaded. This temporarily relocates them to battle-dex, in preparation for a longer-term deduplication probably involving moving the storage.js implementation there. The API has been revised slightly, to match the server's sim/teams.ts.
MathyFurret
pushed a commit
to MathyFurret/pokemon-showdown-client
that referenced
this pull request
Mar 25, 2024
MathyFurret
pushed a commit
to MathyFurret/pokemon-showdown-client
that referenced
this pull request
Mar 25, 2024
PR smogon#2164 added duplicate copies of these functions to battle.ts which is already quite overloaded. This temporarily relocates them to battle-dex, in preparation for a longer-term deduplication probably involving moving the storage.js implementation there. The API has been revised slightly, to match the server's sim/teams.ts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BattleLogunpackTeamandexportTeamunderBattleas replays do not have access to theStoragefunctions.