Fix GSC Toxic interaction with Baton Pass/Heal Bell

[scheibo]

Fixes #3357

[Zarel]

Does the residual damage counter reset on switch-out? I don't remember the report touching on that.

[scheibo]

I'd like a hint in Gen 1, too. PS generally needs more hints.

On it.

If a previously burned/poisoned Pokemon is switched in with Baton Pass from a Pokemon with a Toxic counter, it immediately takes 1/16 * X damage (even though regular poison and burn is 1/8 max HP in Gen 2). If they get passed a Toxic counter and get burned or poisoned later, it's also 1/16 * X, where X is whatever the previous counter was + 1 no matter how many turns have passed.

Gotcha. So the toxic counter kind of 'ruins' the original status's damage and forces it to behave like toxic would.

Unless I'm misunderstanding, onAfterSwitchSelf isn't relevant in Gen 1 because Baton Pass doesn't exist.

I've taken the liberty of deleting it from the Gen 1 code then given we don't think its going to actually occur (no point in retaining dead code).

Does the residual damage counter reset on switch-out? I don't remember the report touching on that.

Oh, you're right, that wasn't covered. I'm going to take a guess and assume it goes away completely through a normal switch, just like how Toxic reverts to regular poison (I've modified the code to behave that way). @Marty-D, is that correct?

[Marty-D]

Unless I'm misunderstanding, onAfterSwitchSelf isn't relevant in Gen 1 because Baton Pass doesn't exist.

I've taken the liberty of deleting it from the Gen 1 code then given we don't think its going to actually occur (no point in retaining dead code).

Oh, really sorry for the confusion but I was answering your question about whether or not the Toxic counter increases there, not switches in general. onAfterSwitchInSelf is definitely needed in Gen 1 for those statuses.

Does the residual damage counter reset on switch-out? I don't remember the report touching on that.

Oh, you're right, that wasn't covered. I'm going to take a guess and assume it goes away completely through a normal switch, just like how Toxic reverts to regular poison (I've modified the code to behave that way). @Marty-D, is that correct?

Yep, normal switching removes the counter.

[scheibo]

onAfterSwitchInSelf is definitely needed in Gen 1 for those statuses.

Reverted back.

[Zarel]

Looks good to me.

[Zarel]

@Marty-D?

[Marty-D]

The counter should be paused while the Pokemon doesn't have a damaging status condition. If something is badly poisoned, takes 3 turns of Toxic damage, then uses Baton Pass into something that isn't statused, then 5 more turns pass, then this new Pokemon gets burned, its next residual damage will be 1/16 * 4. Likewise, in the same situation except the Baton Pass is into a Pokemon that is already burned or poisoned, it immediately takes the 1/16 * 4.

[scheibo]

The counter should be paused while the Pokemon doesn't have a damaging status condition.
Done

[urkerab]

Out of interest, why are you using a sideid here? I would have thought a Side would make more sense (and also simplify the code slightly, see Pokemon.getHeathInner).

[scheibo]

I agree, it would be simpler. I'll update it in a future commit.