Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of the tracing crate #220

Merged
merged 5 commits into from
Feb 23, 2023
Merged

Remove usage of the tracing crate #220

merged 5 commits into from
Feb 23, 2023

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Feb 22, 2023

Close #46

As explained in the issue, despite having tried it for a long time I don't actually see the point of this crate. Spans are confusing and quite useless, and there's no traces sink that works well apart from the same ones as log (stdout and writing to files).

@github-actions
Copy link

github-actions bot commented Feb 22, 2023

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼──────────────────
          +0 ┊ Σ [0 Total Rows]

@tomaka tomaka added this pull request to the merge queue Feb 23, 2023
Merged via the queue into smol-dot:main with commit c6ad1ae Feb 23, 2023
@tomaka tomaka deleted the rm-tracing branch February 23, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove usage of tracing from full node
1 participant