Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update read_exact docs #121

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Update read_exact docs #121

merged 1 commit into from
Dec 28, 2024

Conversation

RCoder01
Copy link
Contributor

I may be missing something, but I don't think that AsyncReadExt::read_exact returns the number of bytes read. It seems like it returns an impl Future<Output = std::io::Result<()>>.

notgull
notgull approved these changes Dec 28, 2024
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@notgull notgull merged commit 275d501 into smol-rs:master Dec 28, 2024
7 checks passed
@RCoder01 RCoder01 deleted the patch-1 branch December 29, 2024 00:12
@notgull notgull mentioned this pull request Dec 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RCoder01 @notgull