fix up headers to remove redundancy and fix some type issues #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smutch
commented
Jan 23, 2024
smutch
commented
Jan 23, 2024
smutch
commented
Jan 23, 2024
smutch
commented
Jan 23, 2024
smutch
commented
Jan 23, 2024
|
Sorry for all of the superfluous indentation and formatting fixes. I have been using the pre-commit checks and auto-formatting fixes. I want to set these checks as automatically applied on all PRs in future, prior to merging. I don't think you need to worry about any of the changes other than the ones I have specifically commented on in this PR. |
smutch
commented
Jan 23, 2024
Merged
smutch
commented
Jan 24, 2024
|
@EMventura - if all seems to be working ok, can you approve this PR and I'll merge? 😄 |
EMventura
approved these changes
Jan 24, 2024
|
Ready for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have removed some redundancy in the header includes but during that process I noticed a few type issues which I have (hopefully) fixed here and not broken anything. I've commented on them below so that @EMventura can take a look and confirm that this is correct.