Fix json object with invalid value and new features #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danifbento
changed the title
|
Hi @danifbento Sorry I missed this! This looks good to me. Thanks for the contributions! |
cycomachead
reviewed
Aug 10, 2021
| url = ngx.var.request_uri or nil, | ||
| query_string = ngx.var.query_string or nil, | ||
| env = { | ||
| REMOTE_ADDR = ngx.var.remote_addr or nil, |
There was a problem hiding this comment.
This is great! I've been meaning to add this. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reporting into Sentry, it gaves this error on the produced event
here was 1 error encountered while processing this eventwhich has the following descriptionreleae: Discarded unknown attribute.It was a miss spelling on the send_report method.
This PR fix the variable naming.
This PR also introduces the concept of
server_namewhich can be configurable or passed using the sender override.This PR also introduces the override for
get_request_datawith some nginx information to be sent to Sentry