feat: sync spaces custom domain with walletconnect allowed origins #487
Conversation
wa0x6e
force-pushed
the
feat-whitelist-custom-domain-for-walletconnect
branch
from
6147398 to
a00278c
Compare
|
We currently have 1033 custom domain, and most of them are not working. Should we import all of them, or import only those working ? |
| @@ -133,4 +140,9 @@ export async function action(body): Promise<void> { | |||
| } | |||
|
|
|||
| if (existingSettings.avatar !== msg.payload.avatar) await clearStampCache('space', space); | |||
|
|
|||
| if (existingSpace?.domain != msg.payload.domain) { | |||
| await addToWalletConnectWhitelist(msg.payload.domain); | |||
There was a problem hiding this comment.
I am still wondering if we want to add all domains (any space to add it) or just turbo spaces
There was a problem hiding this comment.
We need to decide whether we allow domain update for all spaces, or just turbo
There was a problem hiding this comment.
If that's simpler we can allow only for turbo and the ones who already had a domain set to update domain.
There was a problem hiding this comment.
We need to set boundaries on the definition of "already had a domain".
For now, if a non-turbo space has already set a domain, he can change it.
But what happen when a non-turbo space currently has a domain, but remove it (by error, etc ...) ? The way it work now, the space lose the ability to put it back. To enable this, we need a way to mark these spaces as custom domain enabled
There was a problem hiding this comment.
I am still wondering if we want to add all domains (any space to add it) or just turbo spaces
From the various discussions, it seems that the solution would be to whitelist all custom domains, and limit custom domain edition to turbo space, and existing spaces with custom domain
There was a problem hiding this comment.
All i worry about this PR is that someone may add many unwanted domains to walletconnect as any space can add a domain
There was a problem hiding this comment.
All i worry about this PR is that someone may add many unwanted domains to walletconnect as any space can add a domain
Working on a PR to prevent that. domain edition will be limited to turbo, and spaces with existing domains only
There was a problem hiding this comment.
See #488
This PR can be merged after the other one
…s://github.com/snapshot-labs/snapshot-sequencer into feat-whitelist-custom-domain-for-walletconnect
Closes #https://github.com/snapshot-labs/workflow/issues/362
This PR will sync the space's custom domain with WalletConnect allowed origins list, using walletconnect's new API
Changes
How to test
Set the new env vars in your .env
You can create your own (via https://cloud.reown.com/app), or ask for the prod keys
curl -X GET "https://cloud.reown.com/api/get-allowed-domains?projectId=[WALLETCONNECT_PROJECT_ID]" -H "Authorization: [REOWN_SECRET]"(set the correct variables)