-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rari-fuse strategy [rari-fuse] #714
Conversation
This reverts commit 68e2883.
- Hardcode return values to 1 - Comment out unused code
- Comment them out for now.
- The Rari Fuse app links to this address. I think there's one cToken for each distinct collateral type within a fuse pool. The example address given is for the BANK cToken.
Unfortunately, both of the So I'm attempting to reverse engineer them inside the Snapshot Strategy using lower-level calls to the pool ( |
Reading through the FusePoolLens.sol code, I think I can get a user's supplied balance directly from the cToken using:
|
After further study of the cToken implementation on etherscan: https://etherscan.io/address/0x67db14e73c2dce786b5bbbfa4d010deab4bbfcf9#code, I realized that This means that I could plug the Nonetheless, I decided to finish off the PR by changing the variable name from |
After spending 8 hours working on this, I realized that getting a user's balance in a given Rari Fuse market is as simple as calling
I couldn't find precedents for duplicate strategies. I briefly considered creating a PR that contains only the rari-fuse README.md which then points the users to the I also wondered if Considering all this - I decided to simply close this PR and move on. |
I realized my last comment was wrong. In Rari Fuse, there's an exchange rate between the |
* 'master' of github.com:buchaoqun/snapshot-strategies: Update src/strategies/erc3525-vesting-voucher/index.ts Update src/strategies/erc3525-vesting-voucher/index.ts Add rari-fuse strategy [rari-fuse] (snapshot-labs#714) Use brovider in test files (snapshot-labs#717) # Conflicts: # src/strategies/erc3525-vesting-voucher/index.ts
Changes proposed in this pull request:
rari-fuse
strategy that returns the voter's underlying collateral balances in a given Rari Fuse market (fToken).