Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide strategies having alias #956

Closed
wants to merge 5 commits into from
Closed

Conversation

ChaituVR
Copy link
Member

@samuveth
Copy link
Contributor

Why is this needed @ChaituVR ? Do we have an issue?

@ChaituVR
Copy link
Member Author

@samuveth Yea, there is a confusion in users to use strategy erc20-with-balance that it can also actually be used for erc721
so we wanted to rename the strategy to with-balance but some spaces already have erc20-with-balance

with these changes, previous spaces can still use erc20-with-balance but new spaces will be adding with-balance

@samuveth
Copy link
Contributor

samuveth commented Oct 29, 2021

I still don't understand what this filter is for :) @ChaituVR

.filter(s => !s.alias)

@ChaituVR
Copy link
Member Author

haha 😄

@samuveth Filter is just to hide the old strategy names for users to select / to reduce confusion with the duplicate strategy

@bonustrack
Copy link
Member

We will rework that in a later time

@bonustrack bonustrack closed this Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants